Fix #120, Exit console loop on shutdown #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
enhancement
CCB:Ready
astrogeco
added
CCB-20201202
and removed
CCB:Ready
|
CCB 2020-12-02 APPROVED
|
|
Added #668 to cover semtake return. @astrogeco - anything else holding this up? |
Nope, will merge shortly |
@skliper new conflicts after base change :( |
skliper
force-pushed
the
fix120-forever-loop
branch
from
2739d25
to
9d523b6
Compare
|
@astrogeco fixed conflicts. |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Dec 9, 2020
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#652, cmake-based OSAL config
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
This replaces native_osconfig.h and enables running UT as a normal user when SIMULATION=native. Travis-CI requires this.
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
The osconfig.h file is now generated rather than as a normal header file in the source tree. A path must be included to resolve refs in doxygen.
jphickey
added a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Generate an osconfig.h specially for doxygen, independently of the file actually used for the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #120
Replaced condition on forever loops to end on shutdown.
Testing performed
Built and ran unit tests for posix, built on vxworks (planning to build on RTEMs using the latest setup instructions...)
Expected behavior changes
System(s) tested on
Additional context
What about also checking for a semaphore error on posix/rtems (or at least non-interrupt)? Would make it consistent with vxworks.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC