Fix #493, race condition in idmap api test #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a proper "setup" function to create the resources for the test. Add a delay loop to ensure that the child task has executed before continuing with the rest of the test.
|
@skliper any objections with Fast Tracking this? |
skliper
approved these changes
Jun 9, 2020
Approved. |
astrogeco
approved these changes
Jun 10, 2020
|
CCB 2020-06-10: APPROVED |
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Fix nasa#489, Add usersguide/osalguide to local targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Add a delay loop to ensure that the child task has executed before continuing with the rest of the test.
This also uses a separate "setup" function to create the resources for the test and adds asserts that the setup worked.
Fixes #493
Testing performed
Execute unit tests and confirm passing.
Expected behavior changes
No more race condition in idmap-api-test.
System(s) tested on
Ubuntu 20.04 (native)
Centos 6.9 VM (single core)
Additional context
May want to fast track as this causes occasional CI failures in current master branch.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.