Fix #459, dynamically create RAM disk devices on RTEMS #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
Rather than relying on the BSP to preallocate, the ram disk block devices can be created based on request. This correlates with the way RAM disks are implemented on VxWorks and is cleaner and more flexible by making it more independent of the BSP.
skliper
approved these changes
May 18, 2020
|
CCB 20200520 - APPROVED |
|
This is great. I was going to suggest something similar with my GTOSat RTEMS 5 merge, but will rebase my changes on this instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Rather than relying on the BSP to preallocate, the ram disk block devices can be created based on request. This correlates with the way RAM disks are implemented on VxWorks and is
cleaner and more flexible by making it more independent of the BSP.
This allows all the unit tests to work on RTEMS without the needing the BSP to preallocate a ramdisk.
Fixes #459
Testing performed
Build and run all unit tests, and sanity check CFE operation
Expected behavior changes
Unit tests work on RTEMS without BSP preallocating ramdisks
System(s) tested on
RTEMS 4.11 on pc686 via QEMU
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.