Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #455, correct length of device_name in filesys #464

Merged
merged 2 commits into from
May 26, 2020

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented May 14, 2020

Describe the contribution
The device_name field was using the wrong length, it should be of OS_FS_DEV_NAME_LEN
Also correct another length check on the local path name.

Fix #455

Testing performed
Build and execute unit tests, and sanity check CFE operation.

Expected behavior changes
No impact to behavior

System(s) tested on
Ubuntu 20.04 (native)
RTEMS 4.11 on pc686 via QEMU

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

astrogeco and others added 2 commits May 13, 2020 11:49
Integration Candidate COMBINED 2020-04-29 and 2020-05-06
This string should be of OS_FS_DEV_NAME_LEN
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label May 16, 2020
@skliper skliper added this to the 5.1.0 milestone May 16, 2020
@astrogeco
Copy link
Contributor

CCB 20200520 - APPROVED

@skliper skliper added CCB-20200520 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels May 20, 2020
@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label May 26, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate May 26, 2020 13:43
@astrogeco astrogeco merged commit d6b167b into nasa:integration-candidate May 26, 2020
@jphickey jphickey deleted the fix-455-devname-length branch June 19, 2020 16:13
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filesystem using wrong length for device_name field
3 participants