Fix #425, Correct Test_OS_ConvertToArrayIndex assertion typo #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
changed the title
|
@yammajamma amend commit (git commit --amend and force push to fork) to match updated pull request title. Also, use a key word in the description to auto-link the pull request to the issue - |
yammajamma
force-pushed
the
fix-425-Tautological-Assertion-Fix
branch
from
c3469e5
to
eb0230f
Compare
skliper
approved these changes
Apr 20, 2020
skliper
added
the
CCB:Ready
astrogeco
added
the
unit-test
|
CCB 20200422 - APPROVED |
skliper
added
CCB - 20200422
CCB:Approved
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
issue nasa#427, adding travis.yml for cppcheck on flight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #425 Test_OS_ConvertToArrayIndex: tautological assertion
Describe the contribution
Unit test Test_OS_ConvertToArrayIndex implements the following assertion:
osal/src/unit-test-coverage/shared/src/coveragetest-idmap.c
Lines 610 to 611 in 7d9c4c8
UtAssert_True(local_idx1 == local_idx1, "local_idx1 (%lu) == local_idx2 (%lu)",
(unsigned long)local_idx1, (unsigned long)local_idx2);
This is a tautological assertion as it compares local_idx1 with itself.
Update:
local_idx1 is now compared with local_idx2:
UtAssert_True(local_idx1 == local_idx2, "local_idx1 (%lu) == local_idx2 (%lu)",
(unsigned long)local_idx1, (unsigned long)local_idx2);
Testing performed
Steps taken to test the contribution:
Expected behavior changes
System(s) tested on
cFS Dev Server
OS: Ubuntu 18.04
Versions: OSAL 5.0.11.0
Contributor Info - All information REQUIRED for consideration of pull request
Yasir Khan
NASA-GSFC