Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1396, do not use intmax_t/uintmax_t types #1397

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix #1396, do not use intmax_t/uintmax_t types #1397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ut_assert/src/utassert.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@

typedef union
{
intmax_t s; /**< If value is signed */
uintmax_t u; /**< If value is unsigned */
long s; /**< If value is signed */
unsigned long u; /**< If value is unsigned */
} UtAssert_IntBuf_t;

#define UT_COMPARE_TYPE(t, s) (((t) << 1) | (s))
Expand Down Expand Up @@ -417,7 +417,7 @@
return TempBuf;
}

static bool UtAssert_DoCompare(intmax_t ActualValueIn, UtAssert_Compare_t CompareType, UT_IntCheck_t ReferenceValueIn,
static bool UtAssert_DoCompare(long ActualValueIn, UtAssert_Compare_t CompareType, UT_IntCheck_t ReferenceValueIn,

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.

Check notice

Code scanning / CodeQL

Function too long Note

UtAssert_DoCompare has too many lines (75, while 60 are allowed).
bool IsUnsigned)
{
bool Result;
Expand Down