Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1328, always provide UT stub library #1329

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Nov 8, 2022

Checklist (Please check before submitting)

Describe the contribution
Move the UT stub library so it is not dependent on ENABLE_UNIT_TESTS

The "ut_osapi_stubs" library is mostly relevant for testing other applications, as opposed to testing OSAL itself. Therefore this library should be provided regardless of whether OSAL is being tested.

Fixes #1328

Testing performed
Build and check OSAL in standalone build and CFE build

Expected behavior changes
The ut_osapi_stubs library is always available

System(s) tested on
Ubuntu 22.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

The "ut_osapi_stubs" library is mostly relevant for testing other
applications, as opposed to testing OSAL itself.  Therefore this library
should be provided regardless of whether OSAL is being tested.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 8, 2022
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Nov 17, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 17, 2022
*Combines:*

osal v6.0.0-rc4+devtbd

**Includes:**

*cFS*
- #598
- #611

*osal*
- nasa/osal#1335
- nasa/osal#1329

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Justin Figueroa <[email protected]>
Co-authored by: Ariel Adams <[email protected]>
Co-authored by: Daniel Knutsen <[email protected]>
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 17, 2022
*Combines:*

osal v6.0.0-rc4+devtbd

**Includes:**

*cFS*
- #598
- #611

*osal*
- nasa/osal#1335
- nasa/osal#1329
- nasa/osal#1336

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Justin Figueroa <[email protected]>
Co-authored by: Ariel Adams <[email protected]>
Co-authored by: Daniel Knutsen <[email protected]>
@dzbaker dzbaker mentioned this pull request Nov 17, 2022
2 tasks
@dzbaker dzbaker merged commit 615da25 into nasa:main Nov 17, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Nov 17, 2022
*Combines:*

osal v6.0.0-rc4+dev161

**Includes:**

*cFS*
- #598
- #611

*osal*
- nasa/osal#1335
- nasa/osal#1329
- nasa/osal#1336

Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Justin Figueroa <[email protected]>
Co-authored by: Ariel Adams <[email protected]>
Co-authored by: Daniel Knutsen <[email protected]>
@jphickey jphickey deleted the fix-1328-ut-stubs branch December 8, 2022 22:07
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always build/provide OSAL stub library, decouple from ENABLE_UNIT_TESTS
3 participants