Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1305, Stop empty function catching CI workflow format checks #1306

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

thnkslprpt
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Quick fix of #1305

Testing performed
None

Expected behavior changes
Empty function will stop catching up workflow check and causing its failure.

Contributor Info - All information REQUIRED for consideration of pull request
@thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-1305-workflow-check-failure branch from 6dcae06 to 0857ea8 Compare October 7, 2022 02:01
@dzbaker dzbaker linked an issue Oct 13, 2022 that may be closed by this pull request
@dzbaker dzbaker added the CCB:Approved Indicates code review and approval by community CCB label Oct 13, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 17, 2022
*Combines:*

cfe v7.0.0-rc4+dev197
osal v7.0.0-rc4+dev143
psp v1.6.0-rc4+dev61
elf2cfetbl v3.4.0-rc4+dev30
sch_lab v2.5.0-rc4+dev45

**Includes:**

*cFS*
- #589

*cFE*
- nasa/cFE#2165

*osal*
- nasa/osal#1311
- nasa/osal#1310
- nasa/osal#1313
- nasa/osal#1306
- nasa/osal#1309

*psp*
- nasa/PSP#365
- nasa/PSP#368

*sch_lab*
- nasa/sch_lab#126

*elf2cfetbl*
- nasa/elf2cfetbl#119

Co-authored-by: Avi Weiss <[email protected]>
Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Ariel Adams <[email protected]>
@dzbaker dzbaker mentioned this pull request Oct 17, 2022
2 tasks
@dzbaker dzbaker merged commit 1800a6a into nasa:main Oct 17, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 17, 2022
*Combines:*

cfe v7.0.0-rc4+dev197
osal v7.0.0-rc4+dev143
psp v1.6.0-rc4+dev61
elf2cfetbl v3.4.0-rc4+dev30
sch_lab v2.5.0-rc4+dev45

**Includes:**

*cFS*
- #589

*cFE*
- nasa/cFE#2165

*osal*
- nasa/osal#1311
- nasa/osal#1310
- nasa/osal#1313
- nasa/osal#1306
- nasa/osal#1309

*psp*
- nasa/PSP#365
- nasa/PSP#368

*sch_lab*
- nasa/sch_lab#126

*elf2cfetbl*
- nasa/elf2cfetbl#119

Co-authored-by: Avi Weiss <[email protected]>
Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Ariel Adams <[email protected]>
@thnkslprpt thnkslprpt deleted the fix-1305-workflow-check-failure branch October 17, 2022 20:42
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Workflow check catching empty function
3 participants