Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show CodeQL Preview #986

Closed
ArielSAdamsNASA opened this issue May 6, 2021 · 0 comments · Fixed by #987 or #1006
Closed

Show CodeQL Preview #986

ArielSAdamsNASA opened this issue May 6, 2021 · 0 comments · Fixed by #987 or #1006
Assignees
Milestone

Comments

@ArielSAdamsNASA
Copy link
Contributor

ArielSAdamsNASA commented May 6, 2021

Is your feature request related to a problem? Please describe.
Code preview is not available for code scanning results from CodeQL.

Describe the solution you'd like
The preview is available when the osal submodule is checked out rather than the cFS bundle. I have not found a way to checkout just the submodule AND use the tests.

Currently, the workflow checks out the cFS bundle.

    steps:
      - name: Checkout bundle
        uses: actions/checkout@v2
        with:
          repository: nasa/cFS
          submodules: true

      - name: Checkout submodule
        uses: actions/checkout@v2
        with:
          path: osal

To show the preview, only the osal submodule needs to be checked out:

      - name: Checkout submodule
        uses: actions/checkout@v2

Describe alternatives you've considered
Would like to keep the tests, but believe they require the cFS bundle.

Additional context
Community Support Thread: https://github.community/t/codeql-with-submodules/159839/10

The reason is that we currently don’t look for files across submodules for the preview.

Requester Info
Ariel Adams, ASRC Federal

@ArielSAdamsNASA ArielSAdamsNASA self-assigned this May 6, 2021
astrogeco added a commit that referenced this issue May 19, 2021
pepepr08 pushed a commit to pepepr08/osal that referenced this issue Jun 9, 2021
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Fix nasa#986, Remove unnecessary CFE_MSG_Init in TBL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants