Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redefine of NULL #842

Closed
skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #896 or #917
Closed

Remove redefine of NULL #842

skliper opened this issue Mar 10, 2021 · 0 comments · Fixed by #896 or #917
Assignees
@skliper
Labels
CFS-38 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Mar 10, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
The following code will always redefine/define NULL which wasn't the intent

osal/src/os/inc/common_types.h

Lines 128 to 130 in ead5723

#ifndef NULL /* pointer to nothing */
#define NULL ((void *)0)
#endif

Describe the solution you'd like
Remove, NULL is standard C

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC, OSAL code review
@skliper skliper added this to the 6.0.0 milestone Mar 10, 2021
@skliper skliper self-assigned this Mar 11, 2021
skliper added a commit to skliper/osal that referenced this issue Mar 11, 2021
@skliper
Fix nasa#842, Remove NULL redefine
4750bd2
@skliper skliper mentioned this issue Mar 11, 2021
Merged
@astrogeco astrogeco mentioned this issue Mar 17, 2021
Merged
astrogeco added a commit that referenced this issue Mar 17, 2021
@astrogeco
Merge pull request #896 from skliper/fix842-rm_null_redefine
98b0320 
Fix #842, Remove NULL redefine
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@yammajamma
Merge pull request nasa#842 from skliper/fix836-spacecraft-id
2ab77d0 
Fix nasa#836, Replace CFE_MISSION_SPACECRAFT_ID with CFE_PSP_GetSpacecraftId()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
CFS-38 enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #842, Remove NULL redefine skliper/osal
osal Integration Candidate: 2021-03-23 nasa/osal
1 participant
@skliper