Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrub all OSAL UT stub functions #526

Closed
jphickey opened this issue Jun 26, 2020 · 1 comment · Fixed by #527 or #529
Closed

Scrub all OSAL UT stub functions #526

jphickey opened this issue Jun 26, 2020 · 1 comment · Fixed by #527 or #529
Assignees
@jphickey
Labels
enhancement
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Need to scrub all OSAL unit test stub routines, similar to nasa/cFE#762 but for OSAL.

Describe the solution you'd like

  • All functions prototyped in the OSAL public API headers (the src/os/inc dir) should also have a stub defined.
  • All arguments should be registered in the context so the complete context is available within UT hook functions.
  • The argument names should always match the prototype.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Jun 26, 2020
@jphickey
Copy link
Contributor Author

OSAL stubs look fairly complete (the only functions missing from stubs are deprecated) but they do need to have their parameters added.

jphickey added a commit to jphickey/osal that referenced this issue Jun 26, 2020
@jphickey
Fix nasa#526, scrub OSAL stubs
1731baa 
Ensure that:

1. All stub routines register their arguments in the context, so that
   the values will be available to hook functions.
2. Ensure that the argument names used in stubs match the name in the
   prototype/documentation so the value can be retrieved by name.
@jphickey jphickey mentioned this issue Jun 26, 2020
Merged
astrogeco added a commit that referenced this issue Jul 2, 2020
@astrogeco
Merge pull request #527 from jphickey/fix-526-osal-stub-scrub
ac29a87 
Fix #526, scrub OSAL stubs
@astrogeco astrogeco mentioned this issue Jul 25, 2020
Merged
@astrogeco astrogeco added this to the v5.1.0 milestone Sep 21, 2020
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#526 from skliper/fix525-msg-req-scrub
6d541c0 
Fix nasa#525, Message Requirements Scrub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Fix #526, scrub OSAL stubs jphickey/osal
Integration Candidate: 2020-06-24 nasa/osal
2 participants
@jphickey @astrogeco