Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow longer messages in UT assert #491

Closed
jphickey opened this issue Jun 8, 2020 · 0 comments · Fixed by #492 or #511
Closed

Allow longer messages in UT assert #491

jphickey opened this issue Jun 8, 2020 · 0 comments · Fixed by #492 or #511
Assignees
@jphickey
Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

jphickey commented Jun 8, 2020

Is your feature request related to a problem? Please describe.
Currently the UT assert library truncates messages at 128 characters due to the buffer sizes used internally. With macros using function names as well as more complete context info in tests, this is easy to hit.

Describe the solution you'd like
Increase message buffer size and maximum report line length.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
jphickey added a commit to jphickey/osal that referenced this issue Jun 8, 2020
@jphickey
Fix nasa#491, increase UT assert buffer sizes
909d63a 
The buffer for context info increases from 128 to 256 bytes
and the total report buffer to 320 bytes.
@jphickey jphickey self-assigned this Jun 8, 2020
@jphickey jphickey mentioned this issue Jun 8, 2020
Merged
jphickey added a commit to jphickey/osal that referenced this issue Jun 16, 2020
@jphickey
Fix nasa#491, increase UT assert buffer sizes
2d79f8e 
The buffer for context info increases from 128 to 256 bytes
astrogeco added a commit that referenced this issue Jun 17, 2020
@astrogeco
Merge pull request #492 from jphickey/fix-491-utassert-line-length
e05cb2c 
Fix #491, increase UT assert buffer sizes
@astrogeco astrogeco mentioned this issue Jun 17, 2020
Merged
@astrogeco astrogeco added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Sep 28, 2020
@astrogeco astrogeco added this to the v5.1.0 milestone Sep 28, 2020
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#491, Add UT macros
5b66886
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Merge pull request nasa#695 from skliper/fix491-ut-macros
7622827 
Fix nasa#491, Add UT macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Bootes
2 participants
@jphickey @astrogeco