Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global lock for "timecb" objects missing #474

Closed
jphickey opened this issue May 19, 2020 · 1 comment · Fixed by #475 or #482
Closed

Global lock for "timecb" objects missing #474

jphickey opened this issue May 19, 2020 · 1 comment · Fixed by #475 or #482
Assignees
@jphickey
Labels
bug
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Describe the bug
The internal table mutex for the timer callback (timecb) object type is missing/not implemented. This leave a potential race condition as timer callbacks are registered.

To Reproduce
Not observed in real execution at this time - but theoretically possible if two timers are registered by two tasks at the exact same time.

Expected behavior
Should be protected.

System observed on:
Ubuntu 20.04

Additional context
The global lock table is simply missing an entry for this object type.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this May 19, 2020
@jphickey jphickey added the bug label May 19, 2020
@jphickey
Copy link
Contributor Author

Noticed this while investigating #473.

jphickey added a commit to jphickey/osal that referenced this issue May 19, 2020
@jphickey
Fix nasa#474, Add timecb global mutex
eda6210 
The mutex to protect the timer callback (timecb) resource table
was missing.
This was referenced May 19, 2020
Merged
Closed
Merged
@skliper skliper added this to the 5.1.0 milestone May 20, 2020
astrogeco added a commit that referenced this issue May 26, 2020
@astrogeco
Merge pull request #475 from jphickey/fix-474-timecb-lock
aac3e09 
Fix #474, Add timecb global mutex
@astrogeco astrogeco mentioned this issue May 26, 2020
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#474 from stanislaw/root-level-cmake
5a1c7e8 
CMake: minor changes to improve the CLion IDE CMake experience
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Fix #474, Add timecb global mutex jphickey/osal
Integration Candidate 2020-05-20 nasa/osal
2 participants
@jphickey @skliper