Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break up osapi-os-core.h into more focused includes #410

Closed
skliper opened this issue Apr 8, 2020 · 0 comments · Fixed by #675 or #690
Closed

Break up osapi-os-core.h into more focused includes #410

skliper opened this issue Apr 8, 2020 · 0 comments · Fixed by #675 or #690
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Apr 8, 2020

Is your feature request related to a problem? Please describe.
Spawned from #404 discussion - osapi-os-core.h is a monolithic include covering a vast array of APIs, which makes changes harder conceptually separate and manage.

Describe the solution you'd like
Break up osapi-os-core.h - could use the deprecation process to avoid breakage where osapi-os-core.h just includes all the more focused headers.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@jphickey jphickey self-assigned this Apr 8, 2020
@skliper skliper added this to the 6.0.0 milestone Nov 5, 2020
@jphickey jphickey mentioned this issue Dec 9, 2020
Closed
jphickey added a commit to jphickey/osal that referenced this issue Dec 9, 2020
@jphickey
Fix nasa#410, breakup OSAL includes
7cd2fd1 
Includes compatibility wrappers for the old header names.
TODO: needs verification on VxWorks and OMIT_DEPRECATED in compat header.
@skliper skliper mentioned this issue Dec 9, 2020
Merged
@skliper skliper linked a pull request Dec 9, 2020 that will close this issue
Fix #410, breakup includes #675
Merged
jphickey added a commit to jphickey/osal that referenced this issue Dec 10, 2020
@jphickey
Fix nasa#410, breakup OSAL includes
f0bd42e 
Includes compatibility wrappers for the old header names.

Refactors inclusions in all OSAL source files to only include
the components they actually use/refer to.

Refactor all inclusion guards to follow the same general
format (uppercase filename, no leading/trailing underscore)
astrogeco added a commit that referenced this issue Dec 14, 2020
@astrogeco
Merge pull request #675 from jphickey/fix-410-breakup-includes
8dd7415 
Fix #410, breakup includes
@astrogeco astrogeco mentioned this issue Dec 18, 2020
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@dmknutsen
Fix nasa#410, separate SYSLOG configurable defaults for power on and …
95a3a98 
…processor reset
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#625 from dmknutsen/issue_410
2890418 
Fix nasa#410, separate SYSLOG configurable defaults for power on and proc…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #410, breakup includes jphickey/osal
OSAL Integration Candidate: 2020-12-22 nasa/osal
2 participants
@jphickey @skliper