Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSAL fs defines scrub - deprecate OS_VolumeTable and related symbols #367

Closed
skliper opened this issue Mar 4, 2020 · 3 comments · Fixed by #461
Closed

OSAL fs defines scrub - deprecate OS_VolumeTable and related symbols #367

skliper opened this issue Mar 4, 2020 · 3 comments · Fixed by #461
Assignees
@jphickey
Labels
enhancement
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Mar 4, 2020

Is your feature request related to a problem? Please describe.
FS_BASED, RAM_DISK, EEPROM_DISK, ATA_DISK, NUM_TABLE_ENTRIES all missing OS_ prefix
OS_CHK_ONLY and OS_REPAIR defined, but the input to the expected API is a boolean (bool repair)

Describe the solution you'd like
Add prefix, remove unused defines

Describe alternatives you've considered
None

Additional context
Do after #364

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 5.1.0 milestone Mar 13, 2020
@skliper skliper self-assigned this Apr 10, 2020
skliper added a commit to skliper/osal that referenced this issue Apr 10, 2020
@skliper
Fix nasa#367, Scrub FS defines
8b0af52 
Deprecated FS_BASED, RAM_DISK, EEPROM_DISK, ATA_DISK,
NUM_TABLE_ENTRIES, replace with OS_ prefixed defines

OS_CHK_ONLY and OS_REPAIR removed (unused)
@skliper
Copy link
Contributor Author

skliper commented Apr 10, 2020

Started at https://github.com/skliper/osal/tree/fix367-fs-defs-scrub

Further work pending #404 merge to avoid conflicts

@jphickey
Copy link
Contributor

Recommend to deprecate NUM_TABLE_ENTRIES and replace with OS_MAX_FILE_SYSTEMS. The latter already exists as part of #285 / PR #427 and the related scrub of osconfig.h parameters.

@skliper skliper assigned jphickey and unassigned skliper May 11, 2020
@jphickey
Copy link
Contributor

Proposing to deprecate the entire OS_VolumeTable concept and all symbols associated with this. That is: FS_BASED, RAM_DISK, EEPROM_DISK, ATA_DISK, NUM_TABLE_ENTRIES.

Deprecating this also helps with #449. We can keep the backward-compatibility layer in place for now, so the statically-defined OS_VolumeTable[] can still be linked in if OMIT_DEPRECATED is not set. But when it is set, this can be ignored completely.

@jphickey jphickey mentioned this issue May 14, 2020
Closed
@jphickey jphickey mentioned this issue May 14, 2020
Merged
@jphickey jphickey changed the title OSAL fs defines scrub - missing prefix and unused OSAL fs defines scrub - deprecate OS_VolumeTable and related symbols May 15, 2020
@jphickey jphickey mentioned this issue May 15, 2020
Merged
astrogeco added a commit that referenced this issue May 28, 2020
@astrogeco
Merge pull request #461 from jphickey/fix-367-deprecate-voltab
922df4f 
Fix #367, 453, 456, 460, Deprecate OS_VolumeTable and other fixes
jphickey added a commit to jphickey/osal that referenced this issue Aug 10, 2022
@jphickey
CCB 2019-10-09: Approved pull requests nasa#27, nasa#367, nasa#369
6fff82e 
Merge branches 'p27', 'p367' and 'p369' for integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Fix #367, 453, 456, 460, Deprecate OS_VolumeTable and other fixes jphickey/osal
2 participants
@jphickey @skliper