Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap OS_TaskRegister in OMIT_DEPRECATED define #255

Closed
skliper opened this issue Sep 30, 2019 · 5 comments
Closed

Wrap OS_TaskRegister in OMIT_DEPRECATED define #255

skliper opened this issue Sep 30, 2019 · 5 comments
Labels
invalid

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

Comments suggest this function is obsolete, wrap in #ifdef so code can easily be checked for dependence.
@skliper skliper added this to the osal-5.1.0 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 232. Created by jhageman on 2019-07-25T14:59:00, last modified: 2019-08-19T17:29:05

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-07-26 15:13:27:

Milestone renamed

@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-08-14 12:45:44:

CCB 8/14/2019 - Not needed for next gen OSAL, could leave as noop. Mark as deprecate agreed to.

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-08-19 17:29:05:

Changes required to remove internal dependencies (stubs, unit tests, cfe, osal) exceed the level of "quick fix". Pushing to next release.

@skliper skliper assigned skliper and unassigned skliper Sep 30, 2019
@skliper skliper added enhancement and removed bug labels Oct 22, 2019
@skliper skliper mentioned this issue Mar 15, 2020
Closed
skliper added a commit to skliper/osal that referenced this issue Mar 15, 2020
@skliper
Fix nasa#364, Scrub user's guide
4d429de 
Document/comment changes only
Partially addresses nasa#255, nasa#12, nasa#18, nasa#366
@skliper skliper mentioned this issue Mar 15, 2020
Merged
skliper added a commit to skliper/osal that referenced this issue Mar 15, 2020
@skliper
Fix nasa#364, Scrub user's guide
a4abbfc 
Document/comment changes only
Partially addresses nasa#255, nasa#12, nasa#18, nasa#366
@skliper skliper removed their assignment Mar 18, 2020
@skliper skliper removed this from the 5.1.0 milestone Mar 25, 2020
@skliper skliper added this to the 6.0.0 milestone Dec 1, 2020
@skliper skliper changed the title Wrap OS_Taskregister in OMIT_DEPRECATED define Wrap OS_TaskRegister in OMIT_DEPRECATED define Dec 8, 2020
This was referenced Dec 8, 2020
Closed
Merged
Closed
@skliper
Copy link
Contributor Author

skliper commented Dec 8, 2020

OBE - useful in that it checks for task context. More work to remove than worth it, called once by ES from app and child registration so no real impact on apps (they shouldn't call it directly anyways).

@skliper skliper closed this as completed Dec 8, 2020
@skliper skliper removed this from the 6.0.0 milestone Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skliper