Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar graphs should only get latest historical datum #7811

Merged
merged 8 commits into from
Sep 25, 2024

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Aug 12, 2024

Closes #7781

Describe your changes:

Since bar graphs only need the latest telemetry, set the size of historical request to 1

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.82%. Comparing base (de122b9) to head (8e87191).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7811      +/-   ##
==========================================
- Coverage   59.18%   58.82%   -0.37%     
==========================================
  Files         675      675              
  Lines       27284    27284              
  Branches     2671     2671              
==========================================
- Hits        16149    16049     -100     
- Misses      11088    11187      +99     
- Partials       47       48       +1     
Flag Coverage Δ
e2e-ci 61.77% <ø> (-0.01%) ⬇️
e2e-full 23.51% <ø> (-18.46%) ⬇️
unit 51.22% <ø> (-0.13%) ⬇️
Files with missing lines Coverage Δ
src/plugins/charts/bar/BarGraphView.vue 67.64% <ø> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de122b9...8e87191. Read the comment docs.

@ozyx ozyx added this to the Target:4.0.1 milestone Aug 12, 2024
@ozyx ozyx self-requested a review August 27, 2024 18:23
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor comments and a question

e2e/tests/functional/plugins/plot/barGraph.e2e.spec.js Outdated Show resolved Hide resolved
src/plugins/charts/bar/BarGraphView.vue Show resolved Hide resolved
e2e/tests/functional/plugins/plot/barGraph.e2e.spec.js Outdated Show resolved Hide resolved
@shefalijoshi shefalijoshi requested a review from ozyx August 29, 2024 16:47
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the e2e test 10x in a docker env that matches our CI environment demonstrates inherent flakiness due to the lack of determinate waits:

image

I think we should move this test to the openmct-yamcs side so we can test it against real network requests in addition to having deterministic wait conditions via waitForRequest()

Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have tests in the openmct-yamcs PR, let's remove the tests from this PR

e2e/tests/functional/plugins/plot/barGraph.e2e.spec.js Outdated Show resolved Hide resolved
e2e/tests/functional/plugins/plot/barGraph.e2e.spec.js Outdated Show resolved Hide resolved
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 23, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 23, 2024
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 23, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 23, 2024
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 25, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 25, 2024
@unlikelyzero unlikelyzero merged commit e792403 into master Sep 25, 2024
29 of 36 checks passed
@unlikelyzero unlikelyzero deleted the bar-graph-historical-requests branch September 25, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bar charts only need to request one historical value because they can only show one spectrum at a time.
4 participants