Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #54, Update CI_Lab to use osal_id_t #55

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Oct 2, 2020

Describe the contribution
Update the SocketID field to be osal_id_t instead of uint32

Fixes #54

Testing performed
Build and sanity test CFE

Expected behavior changes
None.

System(s) tested on
Ubuntu 20.04

Additional context
This makes it consistent with other modules

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Simple type change for consistency.
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Oct 2, 2020
@astrogeco astrogeco added CCB-20201006 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Oct 6, 2020
@astrogeco
Copy link
Contributor

CCB 2020-10-06 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate October 12, 2020 23:43
@astrogeco astrogeco changed the title Fix #54, Update CI to use osal_id_t Fix #54, Update CI_Lab to use osal_id_t Oct 12, 2020
@astrogeco astrogeco merged commit 671357c into nasa:integration-candidate Oct 12, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Oct 12, 2020
@jphickey jphickey deleted the fix-54-osal-id-type branch June 8, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI_LAB to use osal_id_t typedef
2 participants