Fix #88, consistent application target name #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The application target should not have an "app" suffix. Note that none of the other CFS apps have a suffix either, so this makes CF consistent with that. Also - this removes use of "aux_source_directory" - preference is to list the source files.
jphickey
added
the
CCB:Ready
astrogeco
approved these changes
Dec 6, 2021
pepepr08
approved these changes
Dec 6, 2021
jphickey
force-pushed
the
fix-88-cf-app-name
branch
2 times, most recently
from
e7bc292
to
140c7a8
Compare
astrogeco
added
CCB:Approved
and removed
CCB:Ready
|
CCB:2021-12-08 - APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application target should not have an "app" suffix. Note that none of the other CFS apps have a suffix either, so this
makes CF consistent with that.
Also - this removes use of "aux_source_directory" - preference is to list the source files.
Fixes #88