Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target name inconsistencies - "cf" vs. "cf_app" #88

Closed
jphickey opened this issue Dec 6, 2021 · 1 comment · Fixed by #89
Closed

Target name inconsistencies - "cf" vs. "cf_app" #88

jphickey opened this issue Dec 6, 2021 · 1 comment · Fixed by #89
Assignees
@jphickey
Labels
bug draco-rc1
Milestone
Draco

Comments

@jphickey
Copy link
Contributor

jphickey commented Dec 6, 2021

The name patterns used by other CFS applications do not have an "app" suffix. The "sample_app" is the only exception here, it only has this suffix to differentiate from the "sample_lib".

The build scripts do rely on some naming conventions - in particular the name of the directory should match the name of the main application target. Since this repository is called "CF" (not CF_APP) and is cloned into a directory called "cf", the target name should also be "cf". On the other hand, if the target is named "cf_app" this may problems with things like table builds and app installation, because the names in scripts won't match.

Recommendation is to change the cmake files to build this as a target named only cf and drop any app suffix.
@jphickey jphickey self-assigned this Dec 6, 2021
@jphickey jphickey added the bug label Dec 6, 2021
@jphickey
Copy link
Contributor Author

jphickey commented Dec 6, 2021

Calling this a bug because it does actually break the build when trying to integrate into a system including tables and all.

jphickey added a commit to jphickey/CF that referenced this issue Dec 6, 2021
@jphickey
Fix nasa#88, consistent application target name
140c7a8 
The application target should not have an "app" suffix.  Note
that none of the other CFS apps have a suffix either, so this
makes CF consistent with that.

Also - this removes use of "aux_source_directory" - preference
is to list the source files.
@jphickey jphickey mentioned this issue Dec 6, 2021
Merged
jphickey added a commit to jphickey/CF that referenced this issue Dec 8, 2021
@jphickey
Fix nasa#88, consistent application target name
e7bc292 
The application target should not have an "app" suffix.  Note
that none of the other CFS apps have a suffix either, so this
makes CF consistent with that.

Also - this removes use of "aux_source_directory" - preference
is to list the source files.
@astrogeco astrogeco added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Dec 8, 2021
astrogeco added a commit that referenced this issue Dec 8, 2021
@astrogeco
Merge pull request #89 from jphickey/fix-88-cf-app-name
67fbd32 
Fix #88, consistent application target name
@skliper skliper added this to the Draco milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug draco-rc1
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #88, consistent application target name jphickey/CF
3 participants
@jphickey @skliper @astrogeco