Fix #251, Implement Coding Standard Rules in CodeQL

[ArielSAdamsNASA]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License agreement to [email protected] and copied [email protected].

Describe the contribution
Fix #251
Added JPL rules to configuration guide to follow the coding standard. CodeQL provides some MISRA rules scattered in its repository.

• cpp/ql/src/jsf/4.21 Operators/AV Rule 165.ql - MISRA Rule 5-3-2
• cpp/ql/src/jsf/4.22 Pointers and References/AV Rule 173.ql - MISRA Rule 7-5-2
• cpp/ql/src/jsf/4.21 Operators/AV Rule 157.ql - MISRA Rule 5-14-1
• cpp/ql/src/jsf/4.21 Operators/AV Rule 168.ql - MISRA Rule 5-18-1
• cpp/ql/src/jsf/4.25 Expressions/AV Rule 202.ql - MISRA 6-2-2
• cpp/ql/src/jsf/4.20 Unions and Bit Fields/AV Rule 153.ql - MISRA Rule 9-5-1

Testing performed
Tested locally. JPL rules can be seen here:

Expected behavior changes
CodeQL should scan for violations against JPL rules and a few MISRA rules.

Additional context
Can create a separate workflows. One for the coding standards and another for the security queries.

Note that users can search through results based on rules, but I believe this can be done one rule at a time.

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal

[astrogeco]

Instead of a whole new workflow, you could do multiple jobs that use different config files

[ArielSAdamsNASA]

Instead of a whole new workflow, you could do multiple jobs that use different config files

@astrogeco The JPL and MISRA rules are added in the already existing configuration. There is no new workflow, just the codeql-build.yml workflow. Do you want me to add another configuration file and separate jobs, one for coding standard and one for security, in that one workflow?

[astrogeco]

Do you want me to add another configuration file and separate jobs, one for coding standard and one for security, in that one workflow?

I think that makes sense!