Fix #520, remove cmake_minimum_required in tools #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tools CMakeLists.txt file just adds the subdirectories, it has no logic. The old version being referenced here triggers a deprecation warning, so just remove it.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Jun 28, 2022
dzbaker
added
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
The tools CMakeLists.txt file just adds the subdirectories, it has no logic.
The old version being referenced here triggers a deprecation warning, so just remove it.
Fixes #520
Testing performed
Build using cmake 3.20
Expected behavior changes
No deprecation warning
System(s) tested on
RHEL 8
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.