Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded "cmake_minimum_required" in tools dir #520

Closed
3 tasks done
jphickey opened this issue Jun 28, 2022 · 0 comments · Fixed by #521
Closed
3 tasks done

Remove unneeded "cmake_minimum_required" in tools dir #520

jphickey opened this issue Jun 28, 2022 · 0 comments · Fixed by #521

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the cFS README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
The cmake_minimum_required command currently lists a very old version. In fact some of the CFE/CFS build scripts assume at least version 3.5 to support things like target-specific includes and flags.

Notably, when using a recent version of cmake (e.g. 3.20) this generates a warning that says:

CMake Deprecation Warning at /home/jphickey/code/cfecfs/dtn/tools/CMakeLists.txt:2 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

Describe the solution you'd like
Remove this line here, it is not needed

Additional context
There is no need to specify a minimum version for this, it only adds the subdirectories which each have their own minimum (if specified). Otherwise it inherits the parent build minimum, which is fine.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

dzbaker added a commit that referenced this issue Jul 6, 2022
Fix #520, remove cmake_minimum_required in tools
@dzbaker dzbaker closed this as completed in 6857e96 Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant