-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded "cmake_minimum_required" in tools dir #520
Comments
2 tasks
dzbaker
added a commit
that referenced
this issue
Jul 6, 2022
Fix #520, remove cmake_minimum_required in tools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe.
The
cmake_minimum_required
command currently lists a very old version. In fact some of the CFE/CFS build scripts assume at least version 3.5 to support things like target-specific includes and flags.Notably, when using a recent version of cmake (e.g. 3.20) this generates a warning that says:
Describe the solution you'd like
Remove this line here, it is not needed
Additional context
There is no need to specify a minimum version for this, it only adds the subdirectories which each have their own minimum (if specified). Otherwise it inherits the parent build minimum, which is fine.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: