Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Build, Test, and Run on Push and PR #408

Closed
3 tasks done
ArielSAdamsNASA opened this issue Jan 18, 2022 · 0 comments · Fixed by #409
Closed
3 tasks done

Duplicate Build, Test, and Run on Push and PR #408

ArielSAdamsNASA opened this issue Jan 18, 2022 · 0 comments · Fixed by #409
Assignees

Comments

@ArielSAdamsNASA
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the cFS README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
The Build, Test, and Run workflows do not correctly use the check for duplicates action. The workflows run on both push and pull request. The workflows should skip when triggered by push if it is also triggered by a pull request at the same time.

Describe the solution you'd like
Add if: ${{ needs.checks-for-duplicates.outputs.should_skip != 'true' }}

Describe alternatives you've considered
Keep as is.

Requester Info
Ariel Adams, ASRC Federal

@ArielSAdamsNASA ArielSAdamsNASA self-assigned this Jan 18, 2022
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jan 19, 2022
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jan 19, 2022
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Jan 19, 2022
astrogeco added a commit that referenced this issue Jan 21, 2022
…test-run

Fix #408, Add Check Duplicate for Build, Test, and Run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant