Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #923
Fix #897
Fix #651
Fix #923
Fix #705
Fix #888
Testing performed
See Bundle: https://github.com/nasa/cFS/pull/145/checks
Expected behavior changes
PR #898 - Adds the field
UnregAppID
to track whether an "unregistered" event was generated, un-overloading theEventCount
field to serve its primary purpose of counting actual events generated from a valid/registered AppID.PR #925 - Move the AppID lookup execution to be early in the CFE_SB_SendMsgFull implementation. This avoids double locking between SB+ES and avoids a block-scope local variable.
PR #917 - Instead of identifying a memory pool by its memory address, use a resource ID. IDs are a constant size, regardless of whether the host machine is 32 or 64 bits.
PR #899 - Change from
OS_MAX*
defines to appropriately-scoped CFE defines for array sizingPR #919 - This creates the new
CFE_Status_t
typedef for function's return status codes. Also adds a note toCFE_TBL_GetStatus
since its behavior will likely change in the future in the hopes of not having a non-zero "info" status.System(s) tested on
Bundle CI - https://github.com/nasa/cFS/pull/145/checks
Additional context
Part of nasa/cFS#145
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey
@skliper
@CDKnightNASA