Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #827, Remove old name and id defines #885

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Sep 11, 2020

Describe the contribution
Fix #827, Remove old name and id defines
CFE_PLATFORM_CPU_ID, CFE_PLATFORM_CPU_NAME, and CFE_MISSION_SPACECRAFT_ID

Use CFE_PSP_GetProcessorId(), CFE_PSP_GetProcessorName(), CFE_PSP_GetSpacecraftId() going forward.

Testing performed
Built with unit tests, passed. Also nominal core-cfe run.

Expected behavior changes
None

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
#710

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) enhancement labels Sep 11, 2020
@skliper skliper added this to the 7.0.0 milestone Sep 11, 2020
@astrogeco
Copy link
Contributor

CCB 2020-09-23 APPROVED

@yammajamma yammajamma added CCB-20200923 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Sep 23, 2020
@yammajamma yammajamma changed the base branch from main to integration-candidate September 24, 2020 12:41
Removed CFE_PLATFORM_CPU_ID, CFE_PLATFORM_CPU_NAME,
and CFE_MISSION_SPACECRAFT_ID.  Use CFE_PSP_GetProcessorId(),
CFE_PSP_GetProcessorName(), CFE_PSP_GetSpacecraftId().
@skliper
Copy link
Contributor Author

skliper commented Sep 24, 2020

@yammajamma - resolved conflict.

@yammajamma yammajamma merged commit 6d43c6e into nasa:integration-candidate Sep 24, 2020
@skliper skliper deleted the fix827-remove-old-ids branch February 1, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate CFE_PLATFORM_CPU_ID, CFE_PLATFORM_CPU_NAME, and CFE_MISSION_SPACECRAFT_ID
3 participants