Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #815, remove all deprecated code #817

Merged

Conversation

jphickey
Copy link
Contributor

Describe the contribution
In the next major CFE release, this code will be no longer supported at all. It should be removed early in the cycle
to avoid needing to maintain this compatibility code.

Fixes #815

Testing performed
Build and run, sanity check CFE.
Run all unit tests.

Expected behavior changes
Removes code previously deprecated.
Identical to previous build if the OMIT_DEPRECATED=true flag was set during configuration.

System(s) tested on
Ubuntu 20.04
RTEMS 4.11.3

Additional context
Also depends on nasa/to_lab#55 - should be merged in same cycle.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 18, 2020
@astrogeco
Copy link
Contributor

astrogeco commented Aug 19, 2020

CCB 2020-08-19 APPROVED. Needs more conversation about deprecation timeline and convention for cFS-Caelum

@astrogeco astrogeco added CCB-20200819 CCB:Splinter Item needs a focused splinter meeting labels Aug 19, 2020
@skliper
Copy link
Contributor

skliper commented Aug 19, 2020

@astrogeco - I thought we approved this one? Further discussion required on the topic of removing elements deprecated this cycle before the release of Caelum.

@astrogeco
Copy link
Contributor

@astrogeco - I thought we approved this one? Further discussion required on the topic of removing elements deprecated this cycle before the release of Caelum.

Fixed CCB comment to reflect approval.

@skliper skliper added this to the 7.0.0 milestone Aug 21, 2020
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 26, 2020
@yammajamma
Copy link
Contributor

@jphickey could you please resolve the conflicts here?

In the next major CFE release, this code will be no longer
supported at all.  It should be removed early in the cycle
to avoid needing to maintain this compatibility code.
@jphickey
Copy link
Contributor Author

Rebased. Note that this now includes several blocks with a CFE_OMIT_DEPRECATED_6_8 designation. These were also removed. But it may necessitate doing a 6.9 release of some variety.

@yammajamma yammajamma changed the base branch from main to integration-candidate September 2, 2020 19:43
@astrogeco astrogeco removed the CCB:Splinter Item needs a focused splinter meeting label Sep 2, 2020
@yammajamma yammajamma merged commit e0910fb into nasa:integration-candidate Sep 2, 2020
@jphickey jphickey deleted the fix-815-remove-deprecated branch September 29, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CFE deprecated code for next release
4 participants