Fix #745 - getlastsenderid now returns appid #750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pp id of the last sender
This was
linked to
issues
Jun 19, 2020
|
Marked as 7.0 since this is an API change. Does this also fix #744? I may have missed it, but I don't see where this field is filled in. |
Gah forgot that part! I've committed/pushed. (I can squash merge if you need.) |
|
Closing and will create a new ticket removing the GetLastSenderId() API and adding a variant of RecvMsg() that returns the AppId as an out parameter. |
|
CCB-20200624 - @CDKnightNASA will set up a splinter to further discuss the design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #745 - This removes the CFE_SB_SenderID_t struct and, instead, the CFE_SB_GetLastSenderId() function now takes a pointer to an AppId (uint32) that it uses as an out parameter for the call.
Testing performed
Built with ENABLE_UNIT_TESTS
Expected behavior changes
Significantly changes the GetLastSenderId() function, will break any users of this API (particularly SBN.)
System(s) tested on
Debian 10.3
Additional context
This obviates #744 and I recommend closing that ticket with this fix.
Contributor Info - All information REQUIRED for consideration of pull request
[email protected]