Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #747, Update CFE_SB_TimeStampMsg to save the message pointer argument #748

Merged
merged 3 commits into from
Jul 1, 2020

Conversation

asgibson
Copy link
Contributor

… UT_Stub_CopyFromLocal so that unit tests can check it

Describe the contribution
A clear and concise description of what the contribution is.
Fixes #747

Testing performed
Wrote test that failed when using original version of SB stub CFE_SB_TimeStampMsg.
[ FAIL] 01.001 cf_app_tests.c:90 - CFE_SB_TimeStampMsg received 0xc8230eadc0 and should be 0x61b180
Changed to have stub UT_Stub_CopyFromLocal passed in argument.
[ PASS] 01.001 cf_app_tests.c:90 - CFE_SB_TimeStampMsg received 0x61b180 and should be 0x61b180

Expected behavior changes
Passed in argument value is now available to a test that uses UT_SetDataBuffer for CFE_SB_TimeStampMsg.

System(s) tested on

  • Hardware: PC
  • OS: RHEL7 3.10.0-1062.1.2.el7.x86_64
  • Versions: cFE 6.7

Additional context
None.

Third party code
None.

Contributor Info - All information REQUIRED for consideration of pull request
Alan Gibson, GSFC-0587

astrogeco and others added 3 commits June 10, 2020 19:21
… UT_Stub_CopyFromLocal so that unit tests can check it
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for the time being - but does remind me that we still need to do a scrub to make sure all args are available for hook functions

@astrogeco astrogeco added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jun 23, 2020
@astrogeco astrogeco changed the title Updated CFE_SB_TimeStampMsg to save the message pointer argument with… Fix #747, Update CFE_SB_TimeStampMsg to save the message pointer argument Jun 24, 2020
@astrogeco astrogeco added CCB-20200624 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jun 24, 2020
@astrogeco
Copy link
Contributor

CCB-20200624: Approved

@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Jun 24, 2020
@astrogeco astrogeco changed the base branch from master to integration-candidate July 1, 2020 13:50
@astrogeco astrogeco merged commit cc89553 into nasa:integration-candidate Jul 1, 2020
@skliper skliper added this to the 6.8.0 milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFE_SB_TimeStampMsg in ut_sb_stubs.c does not record MsgPtr argument value
4 participants