Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cFE Integration candidate: Equuleus-rc1+dev13 #2555

Merged
merged 25 commits into from
Jul 2, 2024
Merged

Conversation

dzbaker
Copy link
Collaborator

@dzbaker dzbaker commented May 6, 2024

Checklist (Please check before submitting)

Describe the contribution

Testing performed
cFS Bundle Checks
cFE Checks

Expected behavior changes
See PRs

System(s) tested on
Ubuntu 20.04

Additional context
Add any other context about the contribution here.

Third party code
If included, identify any third party code and provide text file of license

Contributor Info - All information REQUIRED for consideration of pull request
@jphickey
@skliper
@thnkslprpt
@avan989
@chillfig

thnkslprpt and others added 13 commits May 21, 2023 16:18
Cleans up the internal SB implementation so it can better support future
enhancements such as message integrity, additional header fields and
timestamping.
Use a resourceID value for access into the validation result
structure array.  This allows for consistent lookup, matching,
and free/in-use determination, as well as improved resilience
to race conditions and stale data.
Use a resourceID value for access into the dump control
structure array.  This allows for consistent lookup, matching,
and free/in-use determination, as well as improved resilience
to race conditions and stale data.
Restructure some switch statements and add a "default" case so they
are not flagged as having a missing branch in the coverage test.
Fix #2553, fix test that was passing null value
into vsnprintf
Fix #2550, use resourceids for internal table validation and dump control blocks
Fix #2378, refactor SB to support additional use cases
* Not invoked outside of this unit
*
*-----------------------------------------------------------------*/
void CFE_SB_MessageTxn_GetEventDetails(const CFE_SB_MessageTxn_State_t *TxnPtr, const CFE_SB_PipeSetEntry_t *ContextPtr,

Check warning

Code scanning / CodeQL

Poorly documented large function Warning

Poorly documented function: fewer than 2% comments for a function of 127 lines.
DumpCtrlPtr->State = CFE_TBL_DUMP_PENDING;
DumpCtrlPtr->BlockId = CFE_TBL_DUMPCTRLID_C(PendingId);
DumpCtrlPtr->RegRecPtr = RegRecPtr;
DumpCtrlPtr->DumpBufferPtr = DumpBufferPtr;

Check warning

Code scanning / CodeQL

Local variable address stored in non-local memory Warning

A stack address which arrived via a
parameter
may be assigned to a non-local variable.
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL-coding-standard found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@dzbaker dzbaker changed the title cFE Integration candidate: Equuleus-rc1+dev12 cFE Integration candidate: Equuleus-rc1+dev13 May 21, 2024
jdfiguer and others added 11 commits June 14, 2024 09:41
…_report

Fix #2559, Improve CFE_SB_AllocateMessageBuffer error report
Fix #2343, Update CFE_PLATFORM_ES_DEFAULT_SYSLOG_MODE macro in es_verify.h
…n-for-CFE-PLATFORM-SB-HIGHEST-VALID-MSGID

Fix #2116, Update comment re. limits of CFE_PLATFORM_SB_HIGHEST_VALID_MSGID
…-variables-and-parameters

Fix #2375, Use size_t for variables/parameters representing size
…tatus-assignment-in-CFE_SB_CreatePipe

Fix #2495, Remove superfluous status assignment in CFE_SB_CreatePipe
Fix #2552, Adds JSC 2.1 Static Analysis comments
Fix #2529, Reduces CFE_EVS_MAX_PORT_MSG_LENGTH to prevent new line character truncation
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@dzbaker dzbaker merged commit 00fe82a into main Jul 2, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants