Fix #2530, naming convention for SendHkCmd #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects name mismatches in the "SendHkCmd" implementations. ES, EVS, and TBL modules had variations on what this command was named internally in the code.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -443,7 +443,7 @@ | |||
| * See description in header file for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| int32 CFE_ES_HousekeepingCmd(const CFE_ES_SendHkCmd_t *data) | |||
| int32 CFE_ES_SendHkCmd(const CFE_ES_SendHkCmd_t *data) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| @@ -338,7 +338,7 @@ | |||
| * See description in header file for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| int32 CFE_EVS_ReportHousekeepingCmd(const CFE_EVS_SendHkCmd_t *data) | |||
| int32 CFE_EVS_SendHkCmd(const CFE_EVS_SendHkCmd_t *data) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| @@ -42,7 +42,7 @@ | |||
| * See description in header file for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| int32 CFE_TBL_HousekeepingCmd(const CFE_MSG_CommandHeader_t *data) | |||
| int32 CFE_TBL_SendHkCmd(const CFE_TBL_SendHkCmd_t *data) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| @@ -1319,7 +1319,7 @@ | |||
| /* | |||
| ** Test the function that processes housekeeping request message | |||
| */ | |||
| void Test_CFE_TBL_HousekeepingCmd(void) | |||
| void Test_CFE_TBL_SendHkCmd(void) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion Note
| @@ -443,7 +443,7 @@ | |||
| * See description in header file for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| int32 CFE_ES_HousekeepingCmd(const CFE_ES_SendHkCmd_t *data) | |||
| int32 CFE_ES_SendHkCmd(const CFE_ES_SendHkCmd_t *data) | |||
Check notice
Code scanning / CodeQL-coding-standard
Function too long Note
| @@ -42,7 +42,7 @@ | |||
| * See description in header file for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| int32 CFE_TBL_HousekeepingCmd(const CFE_MSG_CommandHeader_t *data) | |||
| int32 CFE_TBL_SendHkCmd(const CFE_TBL_SendHkCmd_t *data) | |||
Check notice
Code scanning / CodeQL-coding-standard
Function too long Note
| @@ -1319,7 +1319,7 @@ | |||
| /* | |||
| ** Test the function that processes housekeeping request message | |||
| */ | |||
| void Test_CFE_TBL_HousekeepingCmd(void) | |||
| void Test_CFE_TBL_SendHkCmd(void) | |||
Check notice
Code scanning / CodeQL-coding-standard
Function too long Note
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Mar 21, 2024
*Combines:* cFE equuleus-rc1+dev114 sample_app equuleus-rc1+dev46 **Includes:** *cFE* - nasa/cFE#2387 - nasa/cFE#2531 *sample_app* - nasa/sample_app#218 - nasa/sample_app#216 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Avi Weiss <[email protected]>
This was referenced Mar 21, 2024
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Mar 21, 2024
*Combines:* cFE equuleus-rc1+dev114 sample_app equuleus-rc1+dev46 **Includes:** *cFE* - nasa/cFE#2387 - nasa/cFE#2531 *sample_app* - nasa/sample_app#218 - nasa/sample_app#216 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Avi Weiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Corrects name mismatches in the "SendHkCmd" implementations. ES, EVS, and TBL modules had variations on what this command was named internally in the code.
Fixes #2530
Testing performed
Run all tests
Expected behavior changes
None
System(s) tested on
Debain
Additional context
In the main line build this is just for code consistency and pattern compliance, as this name isn't exposed externally. It does, however, start to matter when using generated header files.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.