Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2421, adjust dependencies on table lib #2422

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Aug 9, 2023

Checklist (Please check before submitting)

Describe the contribution
Instead of having the intermediate table library build as part of the "all" target, attach it as a dependency under the custom rule. This way it will only be built in the context of the cfetables top level target, not both.

Fixes #2421

Testing performed
Build a configuration with lots of tables (> 100) repeatedly from a clean start using various -j values.

Expected behavior changes
Builds succeed, no race conditions/sporadic failures.

System(s) tested on
Debian

Additional context
This excludes the intermediate library from the all target and instead attaches it explicitly under the generate tables rule. So it should avoid the case of having two legs of a parallel build both finding the dependency and attempting to build it.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Instead of having the intermediate table library build as part of the "all"
target, attach it as a dependency under the custom rule.  This way it will
only be built in the context of the cfetables top level target, not
both.
@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Aug 10, 2023
@dzbaker dzbaker merged commit 6bdeee5 into nasa:main Aug 15, 2023
22 checks passed
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) CCB:FastTrack labels Aug 17, 2023
@dmknutsen dmknutsen added this to the Equuleus milestone Aug 23, 2023
@jphickey jphickey deleted the fix-2421-parallel-build branch November 16, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB Equuleus-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional table build failures with parallel builds (-j)
3 participants