Fix #2296, add option to link to generated files #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the "generate_config_includefile" to be aware of generated files. This should not call cfe_locate_implementation_file() in this context because the file may not exist at the time. For this type of use case it should just directly link the file without any checking.
jphickey
added
the
CCB:Ready
3 tasks
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Apr 25, 2023
*Combines:* cFE v7.0.0-rc4+dev276 osal v6.0.0-rc4+dev213 PSP v1.6.0-rc4+dev76 **Includes:** *cFE* - nasa/cFE#2299 - nasa/cFE#2300 - nasa/cFE#2298 *osal* - nasa/osal#1383 *PSP* - nasa/PSP#391 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Dylan Z. Baker <[email protected]>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Apr 25, 2023
*Combines:* cFE v7.0.0-rc4+dev276 osal v6.0.0-rc4+dev213 PSP v1.6.0-rc4+dev76 **Includes:** *cFE* - nasa/cFE#2299 - nasa/cFE#2300 - nasa/cFE#2298 *osal* - nasa/osal#1383 *PSP* - nasa/PSP#391 Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Dylan Z. Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Update the "generate_config_includefile" to be aware of generated files. This should not call cfe_locate_implementation_file() in this context because the file may not exist at the time. For this type of use case it should just directly link the file without any checking.
Fixes #2296
Testing performed
Build HS (with additional patch) that needs this
Expected behavior changes
Files that are expected to be generated (e.g. via EDS tool) do not need to exist.
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.