Fix #2228, Update UTs to use correct cmd types #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix nasa#2228, Update UTs to use correct cmd types
dmknutsen
added
the
CCB:Ready
jphickey
requested changes
Dec 8, 2022
There was a problem hiding this comment.
If you want, I could theoretically take this one and do the updates I suggested. The problem is the change as proposed will break the EDS build. (Fundamental issue is that we don't actually define a real message called NoArgsCmd in any of these modules; that was just an implementation shortcut to avoid repeating the same definition, so it really shouldn't be referenced outside of the msg.h file).
Update remaining cases where the CFE_MSG_CommandHeader_t was used for a command that had no arguments, replacing it with a real data type that is named according to the command. In particular, this introduces a "SendHkCmd" type into all modules, where previously the HK command used CFE_MSG_CommandHeader_t directly.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -655,7 +655,7 @@ | |||
| * See description in header file for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| int32 CFE_ES_HousekeepingCmd(const CFE_MSG_CommandHeader_t *data) | |||
| int32 CFE_ES_HousekeepingCmd(const CFE_ES_SendHkCmd_t *data) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
| @@ -613,7 +613,7 @@ | |||
| * See description in header file for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| int32 CFE_EVS_ReportHousekeepingCmd(const CFE_MSG_CommandHeader_t *data) | |||
| int32 CFE_EVS_ReportHousekeepingCmd(const CFE_EVS_SendHkCmd_t *data) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
| @@ -503,7 +503,7 @@ | |||
| * See description in header file for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| int32 CFE_SB_SendHKTlmCmd(const CFE_MSG_CommandHeader_t *data) | |||
| int32 CFE_SB_SendHKTlmCmd(const CFE_SB_SendHkCmd_t *data) | |||
Check notice
Code scanning / CodeQL-coding-standard
Long function without assertion
| @@ -655,7 +655,7 @@ | |||
| * See description in header file for argument/return detail | |||
| * | |||
| *-----------------------------------------------------------------*/ | |||
| int32 CFE_ES_HousekeepingCmd(const CFE_MSG_CommandHeader_t *data) | |||
| int32 CFE_ES_HousekeepingCmd(const CFE_ES_SendHkCmd_t *data) | |||
Check notice
Code scanning / CodeQL-coding-standard
Function too long
jphickey
approved these changes
Dec 9, 2022
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 20, 2022
*Combines:* cFE v7.0.0-rc4+dev242 t0_lab v2.5.0-rc4+dev35 **Includes:** *cFE* - nasa/cFE#2231 - nasa/cFE#2229 - nasa/cFE#2192 *to_lab* - nasa/to_lab#142 Co-authored by: Daniel Knutsen <[email protected]> Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Avi Weiss: <[email protected]>
This was referenced Dec 20, 2022
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Dec 20, 2022
*Combines:* cFE v7.0.0-rc4+dev242 to_lab v2.5.0-rc4+dev35 **Includes:** *cFE* - nasa/cFE#2231 - nasa/cFE#2229 - nasa/cFE#2192 *to_lab* - nasa/to_lab#142 Co-authored by: Daniel Knutsen <[email protected]> Co-authored by: Justin Figueroa <[email protected]> Co-authored by: Joseph Hickey <[email protected]> Co-authored by: Avi Weiss: <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2228, Update UTs to use correct cmd types
Checklist (Please check before submitting)
Describe the contribution
These are the unit test updates requested by @shion-ito-nasa, and are associated with #2228
The requested change originated from #2220
Testing performed
Build and run all tests'
Expected behavior changes
No impact to behavior
System(s) tested on
Ubuntu 22.04 and 20.04 (workflows)
Contributor Info - All information REQUIRED for consideration of pull request
Dan Knutsen
NASA/Goddard