Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2183, use osal_public_api header targets in doc #2184

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

jphickey
Copy link
Contributor

@jphickey jphickey commented Oct 25, 2022

Checklist (Please check before submitting)

Describe the contribution
Ensure that osal_public_api_headerlist is a dependency of all the doc builds. Also adds the OSAL top level directory to the mission build which will define the osal_public_api target, and thus not require the path to be repeated.

Fixes #2183

Testing performed
Build documentation from clean build area

Expected behavior changes
Order of operations with doc targets does not matter anymore, as the file gets generated correctly no matter which target is built first.

System(s) tested on
Ubuntu

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Ensure that `osal_public_api_headerlist` is a dependency of all the doc
builds.  Also adds the OSAL top level directory to the mission build
which will define the `osal_public_api` target, and thus not require the
path to be repeated.
@jphickey jphickey requested a review from dzbaker October 25, 2022 20:49
@dzbaker dzbaker added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) CCB:FastTrack labels Oct 25, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 26, 2022
*Combines:*

cfe v7.0.0-rc4+dev201
osal v6.0.0-rc4+dev147

**Includes:**

*cFS*
- #594
- #559

*cFE*
- nasa/cFE#2184

*osal*
- nasa/osal#1319

Co-authored by: Ariel Adams <[email protected]>
Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Haven Carlson <[email protected]>
@dzbaker dzbaker merged commit 9a02fd7 into nasa:main Oct 26, 2022
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 26, 2022
*Combines:*

cfe v7.0.0-rc4+dev201
osal v6.0.0-rc4+dev147

**Includes:**

*cFS*
- #594
- #559

*cFE*
- nasa/cFE#2184

*osal*
- nasa/osal#1319

Co-authored by: Ariel Adams <[email protected]>
Co-authored by: Joseph Hickey <[email protected]>
Co-authored by: Haven Carlson <[email protected]>
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Oct 27, 2022
@jphickey jphickey deleted the fix-2183-doc-dependency branch November 30, 2022 15:09
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB CCB:FastTrack draco-rc4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependency on osal_public_api targets for OSAL headers
3 participants