Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cFE Integration candidate: 2021-08-24 #1839

Merged
merged 59 commits into from
Aug 21, 2021
Merged

cFE Integration candidate: 2021-08-24 #1839

merged 59 commits into from
Aug 21, 2021

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Aug 18, 2021

Describe the contribution

PR #1803

Add software bus tests

PR #1756

PR #1809

PR #1842

PR #1844

PR #1828

Improve tbl coverage tests

PR #1833

PR #1832

PR #1836

PR #1848

PR #1845

  • HOTFIX IC-20210819, type correction TBL coverage test

PR #1832

PR #1806

PR #1813

PR #1814

PR #1811

PR #1822

PR #1816

PR #1854

PR #1855

PR #1853

PR #1859

PR #1856

PR #1857

PR #1782

Testing performed
cFE CI https://github.com/nasa/cFE/pull/1839/checks
cFS Bundle CI https://github.com/nasa/cFS/pull/340/checks

Expected behavior changes
See PRs

System(s) tested on
Ubuntu CI

Additional context
Part of nasa/cFS#340

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
@ArielSAdamsNASA
@pepepr08
@zanzaben
@skliper
@astrogeco
@jphickey
@nmullane

nmullane and others added 23 commits August 12, 2021 13:56
In the default config, the maximum bucket size for the SB pool was not
quite big enough to allocate a message of CFE_MISSION_SB_MAX_SB_MSG_SIZE
- only missing two small sections which are not at all possible to cover
Add tests for the CFE SB subscription API:
 - CFE_SB_Subscribe
 - CFE_SB_SubscribeEx
 - CFE_SB_SubscribeLocal
 - CFE_SB_Unsubscribe
 - CFE_SB_UnsubscribeLocal
Ensure a separate stack variable, always named "OsStatus", is used
to hold the result of an OSAL API call.  Do not use the same variable
that is used to store a CFE status code.
Ensure a separate stack variable, always named "PspStatus", is used
to hold the result of a PSP API call.  Do not use the same variable
that is used to store a CFE status code.
Add tests for the basic message passing API:
 - CFE_SB_TransmitMsg
 - CFE_SB_ReceiveBuffer
Add tests for the CFE SB subscription API:
- CFE_SB_AllocateMessageBuffer
- CFE_SB_ReleaseMessageBuffer
- CFE_SB_TransmitBuffer
Adds success test and boundary conditions test for
CFE_TBL_ReleaseAddresses
astrogeco and others added 23 commits August 19, 2021 15:13
Fix #473 Adding coverage tests to cFE TIME
Status code no longer produced by current implementation, it passes
through the ES error which will be CFE_ES_ERR_RESOURCEID_NOT_VALID.
Simple search and replace error
Stale error code no longer produced by implementation
 - The end child task API is void, so can't return error code
 - Requirement name fix for Report Application ID (added By Name)
Status code no longer produced by current implementation, it
returns CFE_TBL_ERR_ACCESS when unable to open a file.
Fix #1847, enable strict resource id w/OMIT_DEPRECATED
HOTFIX IC-20210819, type correction TBL coverage test
- Fixed test to work with strict resource id types
…ound-wakeup

Fix #1805, Add test for ES BackgroundWakeup
…fe_es_restartapp

Fix #1786, Success Test for CFE_ES_RestartApp
…greater-cfe_platform_sb_default_msg_limit

Fix #1794, Subscribe to Message Limit Greater Than CFE_PLATFORM_SB_DEFAULT_MSG_LIMIT
…fe_es_getmempoolstats

Fix #1787, Success Test for CFE_ES_GetMemPoolStats
Fix #1821, Group MSG APIs documentation by header type
Fix #1851, remove unused CFE_TBL_ERR_BAD_APP_ID
Fix #1852, correct syslog message in pool create
Fix #1850, remove unused CFE_ES_POOL_BOUNDS_ERROR
Fix #1858, remove unused CFE_TBL_ERR_FILE_NOT_FOUND

Fix #1863, Remove comment referencing CFE_TBL_ERR_FILE_NOT_FOUND
Fix #1827 Check error ctr to TransmitMsg test
Fix #1771, End Child Task requirement remove error code
…al-tests

Fix #1679, Add functional tests for resource misc
@astrogeco
Copy link
Contributor Author

Workflows passing in fork when using integration-candidate bundle
https://github.com/astrogeco/cFE/runs/3386692864

@astrogeco astrogeco marked this pull request as ready for review August 20, 2021 23:52
@astrogeco astrogeco merged commit 5e41330 into main Aug 21, 2021
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment