cFE Integration candidate: 2021-03-02 #1196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #1020, refactor SB buffer descriptor object
Fix #922, Update
cfe_error.h
to use theCFE_Status_t
typeFix #1149, remove cfeesugshellsrv from user guide
Fix #546 , APIs missing argument validation
Fix #547 , APIs missing check for NULL pointer(s)
Fix #1119 , Calculate crc can't return error code
Fix #1153, Remove logic based on LogEnabled status
Fix #1189, correct compiler warnings
Testing performed
See https://github.com/nasa/cFS/pull/204/checks
Expected behavior changes
PR #1154 - Refactors the SB buffer descriptor object
CFE_SB_BufferD_t
and simplify the zero-copy buffer paradigm. Combines the zero-copy and the normal CFE buffer descriptor into a single unifiedCFE_SB_BufferD_t
object. Results in a simpler zero-copy design that is similarto the the standard, non-zero-copy message path. All message descriptor objects are now tracked in a list by SB. All changes are internal to SB. This does not affect API or behavior of any existing APIs (but see note). Corrects a minor issue where theMsgSendErrorCounter
would get incremented if there were no subscribers, but only in the zero copy API.PR #935 - Replaces
int_32
withCFE_Status_t
for all error message codesPR #1179 - Removes references to
cfeesugshellsrv
from user guidePR #1140 - Adds null pointer checks and size checks to validate method parameters. Returning the input instead of an error code
PR #1178 - Removes use of
LogEnabled
element in HK telemetry for EVS logic since log is always enabled now. On failures, reset area or semaphore will panic.PR #1197 - Fixes various build warnings when
BUILDTYPE=release
.System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#204
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@jphickey
@pducolin
@zanzaben
@skliper