cFE Integration Candidate: 2020-11-24 #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the unit tests, unit test support, and stubs to replace deprecated SB APIs with MSG APIs.
Update documentation to replace deprecated SB APIs with MSG APIs
Update the core software from the deprecated SB APIs to the MSG APIs.
Add an extra write of a null char which squelches a warning.
Do not enforce CFE_PLATFORM_ES_DEFAULT_STACK_SIZE as a minimum, it should be a default.
The "osal_id_t" type isn't defined in any of the CFE message/interface header files for use within telemetry. This ID is an ephemeral runtime value and is not relevant to a ground system or anything outside CFE, so it makes most sense to simply remove this ID from the telemtry structure. Note that all commands are name-based, not ID-based, hence why this ID is not really useful.
The type of this should be CFE_ES_ResourceID_t, not uint32
Rather than directly referencing a constant, prefer to use the sizeof() operator on the instance or type whenever possible.
Update use of uint32 to size_t in UT support code
Fix all use of uint32 for sizes, replace with size_t Scrub all other types to make sure use is consistent, using proper typedef whenever available.
Fix all use of uint32 for sizes, replace with size_t Scrub all other types to make sure use is consistent, using proper typedef whenever available.
Fix all use of uint32 for sizes, replace with size_t Scrub all other types to make sure use is consistent, using proper typedef whenever available.
Fix all use of uint32 for sizes, replace with size_t Scrub all other types to make sure use is consistent, using proper typedef whenever available.
Fix all use of uint32 for sizes, replace with size_t Scrub all other types to make sure use is consistent, using proper typedef whenever available.
Fix #663, more consistent use of data types
|
@skliper we have a doxygen warning |
|
@astrogeco fixed. |
Co-authored-by: Gerardo E. Cruz-Ortiz <[email protected]>
astrogeco
pushed a commit
to astrogeco/cFE
that referenced
this pull request
Dec 1, 2020
Fix #965, remove OSAL ID from App/LibInfo struct
Remove reference to `CFE_MSG_Message_t` in doxygen comments
Integration Candidate 2020-11-24
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Dec 3, 2020
Combines nasa/cFE#1027 nasa/osal#662 nasa/PSP#221 nasa/sample_app#113 nasa/sample_lib#38 nasa/sch_lab#58 nasa/tblCRCTool#25 Co-authored-by: Joseph Hickey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #777, Use MSG APIs
Fix #1016, bogus warning in strncpy
Fix #1004, default stack size
Fix #965, remove OSAL ID from App/LibInfo struct
Fix #1023, correct stub appid parameter
Fix #663, More consistent use of datatypes
Testing performed
See events for "github actions test" at https://github.com/astrogeco/cFS/actions
Expected behavior changes
PR #1003 - Backward compatible API change. Replace many uses of generic uint16 and uint32 with a more purpose-specific type. Replace all sizes with size_t across the API.
PR #1007 - Rename
UT_SetForceFailtoUT_SetDefaultReturnValuesince some functions that retain more than 1 value are not necessarily failingPR #998 and #1028 - Deprecates many SB Elements and replaces them with the new MSG module. See #777 for list.
PR #1017 - App and Lib info telemetry structures no longer contain the
ModuleIdvalue from OSAL.PR #1018 - Add an extra write of a null char after
strncpywhich squelches a warning and appease compiler warning logic.PR #1022 - Uses
CFE_PLATFORM_ES_DEFAULT_STACK_SIZEas a default instead of a minimum. Affects the Start App command; if stack size is specified as zero, then the default stack size value from platform config is used. Otherwise the value in the command will be passed through and used as-is.PR #1024 - Changes the type of the AppID parameter on "Cleanup" routines from
uint32toCFE_ES_ResourceID_t.System(s) tested on
Ubuntu 18.04
Additional context
Part of nasa/cFS#158
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
@skliper
@jphickey
@zanzaben