Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

low CFE_MISSION_MAX_FILE_LEN and CFE_TBL_FILEDEF(..., "sample_app_table.tbl") causes silent non-truncation #730

Closed
CDKnightNASA opened this issue Jun 3, 2020 · 2 comments · Fixed by #738 or #756
Closed

low CFE_MISSION_MAX_FILE_LEN and CFE_TBL_FILEDEF(..., "sample_app_table.tbl") causes silent non-truncation #730

CDKnightNASA opened this issue Jun 3, 2020 · 2 comments · Fixed by #738 or #756
Assignees
@CDKnightNASA
Labels
bug cFE-TBL Table services
Milestone
Bootes

Comments

@CDKnightNASA
Copy link
Contributor

Describe the bug
I was scratching my head why my table file was named "sample_app_table.tbl\004" until I realized that CFE_MISSION_MAX_FILE_LEN is defined as "20" and "sample_app_table.tbl" is exactly 20 characters. If I had one more char, the compiler would err. But it accepts static definition of structs using strings that are the exact length, which loses the null terminator.

Expected behavior
Should allow file names of CFE_MISSION_MAX_FILE_LEN chars.

Reporter Info
[email protected]
@CDKnightNASA CDKnightNASA added the cFE-TBL Table services label Jun 3, 2020
@CDKnightNASA CDKnightNASA self-assigned this Jun 3, 2020
CDKnightNASA added a commit to CDKnightNASA/cFE that referenced this issue Jun 3, 2020
@CDKnightNASA
fix nasa#730 - adds padding to CFE_TBL_FileDef_t
119e62b
@CDKnightNASA CDKnightNASA linked a pull request Jun 3, 2020 that will close this issue
fix #730 - adds padding to CFE_TBL_FileDef_t #731
Closed
This was referenced Jun 5, 2020
Closed
Closed
CDKnightNASA added a commit to CDKnightNASA/cFE that referenced this issue Jun 5, 2020
@CDKnightNASA
fix nasa#730 - adds null to FILEDEFs
c37197e
@ericgilligan-nasa
Copy link

I ran into this exact same issue today. Was scratching my head for a long time on it

@CDKnightNASA CDKnightNASA mentioned this issue Jun 11, 2020
Merged
@CDKnightNASA
Copy link
Contributor Author

I ran into this exact same issue today. Was scratching my head for a long time on it

Then you can test out my pull request :D (I seriously forgot to create it.) Note that it's PR #738 that you want to test out...The other PR linked to this was a previous idea that I scrapped, and had accidentally merged in a different branch into the PR branch. Whoop.

astrogeco added a commit that referenced this issue Jun 23, 2020
@astrogeco
Merge pull request #738 from CDKnightNASA/fix-730-tbl_filedef_nulls
dcb00a4 
Fx #730, Adds null to FILEDEFs
@astrogeco astrogeco mentioned this issue Jun 23, 2020
Merged
astrogeco pushed a commit that referenced this issue Jul 1, 2020
@CDKnightNASA @astrogeco
fix #730 - adds null to FILEDEFs
d8e09b5
@skliper skliper removed a link to a pull request Jul 27, 2020
fix #730 - adds padding to CFE_TBL_FileDef_t #731
Closed
@astrogeco astrogeco added the bug label Sep 15, 2020
@skliper skliper added this to the 6.8.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CDKnightNASA CDKnightNASA

Labels
bug cFE-TBL Table services
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

fix #730 - adds null to FILEDEFs CDKnightNASA/cFE
Integration Candidate: 2020-06-17 nasa/cFE
4 participants
@CDKnightNASA @skliper @astrogeco @ericgilligan-nasa