Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global build options no longer global #644

Closed
skliper opened this issue Apr 27, 2020 · 2 comments · Fixed by #635
Closed

Global build options no longer global #644

skliper opened this issue Apr 27, 2020 · 2 comments · Fixed by #635
Assignees
@jphickey
Labels
bug
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Apr 27, 2020

Describe the bug
Deprecation flags not showing up in build for cFE/apps/PSP

To Reproduce
Prep with SIMULATION=native ENABLE_UNIT_TEST=true OMIT_DEPRECATED=true
make VERBOSE=true and see the DEPRECATED flags not applied to cFE/apps/PSP

Expected behavior
Global flags should be global

Code snips
None

System observed on:

Additional context
Critical for CI testing...

Reporter Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the bug label Apr 27, 2020
@skliper skliper added this to the 6.8.0 milestone Apr 27, 2020
@jphickey jphickey self-assigned this Apr 27, 2020
jphickey added a commit that referenced this issue Apr 27, 2020
@jphickey
Fix #644, Append directory properties
b1ef9fc 
The set_directory_properties() function overwrites existing properties.
Normally the properties were empty but the global_build_options.cmake
might make it non-empty (e.g. OMIT_DEPRECATED).

Using set_property() signature instead has an option to APPEND rather
than overwrite.
@jphickey
Copy link
Contributor

Diagnosis is that the recent change for #585 (flag propagation) needs to append rather than set.

Fix is pushed directly to "integration-candidate" branch (fairly trivial). See commit above for review.

@skliper skliper linked a pull request Apr 27, 2020 that will close this issue
Integration Candidate: 2020-04-15 #635
Merged
@skliper
Copy link
Contributor Author

skliper commented Apr 27, 2020

Diagnosis is that the recent change for #585 (flag propagation) needs to append rather than set.

Fix is pushed directly to "integration-candidate" branch (fairly trivial). See commit above for review.

Thanks for the quick fix. Worked for me. Linked issue directly to IC PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Integration Candidate: 2020-04-15 nasa/cFE
2 participants
@jphickey @skliper