Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES comments need checked for consistency #275

Open
skliper opened this issue Sep 30, 2019 · 5 comments · May be fixed by #671
Open

ES comments need checked for consistency #275

skliper opened this issue Sep 30, 2019 · 5 comments · May be fixed by #671
Assignees
@skliper
Labels
docs This change only affects documentation. enhancement good first issue Good for newcomers

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

Lots of copy/paste type errors in ES. For example, after CFE_ES_IncrementTaskCounter() the comment says /* End of CFE_ES_ExitChildTask() */
@skliper skliper added this to the 6.7.1 milestone Sep 30, 2019
@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper added the bug label Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 244. Created by sseeger on 2018-08-14T19:37:54, last modified: 2019-07-03T12:48:08

@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Trac comment by jhageman on 2019-07-03 12:48:08:

Moved unfinished 6.6.1 issues to next minor release

@skliper skliper removed their assignment Sep 30, 2019
@skliper skliper modified the milestones: 6.7.1, 6.7.0, 6.8.0 Sep 30, 2019
@skliper skliper added the good first issue Good for newcomers label Nov 4, 2019
@skliper
Copy link
Contributor Author

skliper commented Nov 17, 2019

Just piling on, /* end of file */ in the middle of the file and a handful of others.

@skliper skliper added enhancement and removed bug labels Feb 26, 2020
@skliper
Copy link
Contributor Author

skliper commented May 5, 2020

Comments and format cleanup planned once this round of PRs are closed

@skliper skliper added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 5, 2020
skliper added a commit to skliper/cFE that referenced this issue May 5, 2020
@skliper
Fix nasa#275, ES comment cleanup
fcfb7cb
@skliper skliper linked a pull request May 5, 2020 that will close this issue
Draft
@skliper skliper self-assigned this May 5, 2020
@skliper skliper modified the milestones: 6.8.0, 7.0.0 Jun 5, 2020
@skliper skliper added the docs This change only affects documentation. label Mar 30, 2021
This was referenced Apr 8, 2021
Closed
Closed
This was referenced Apr 19, 2021
Closed
Closed
@skliper skliper removed this from the 7.0.0 milestone Sep 24, 2021
This was referenced Oct 5, 2022
Closed
Closed
@thnkslprpt
Copy link
Contributor

Most or all of the typos/mistakes that were originally noticed when this issue was opened have probably been cleared up by now.

I would suggest that this can be closed as completed by recent commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
docs This change only affects documentation. enhancement good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(WIP) Fix #275, ES comment cleanup skliper/cFE
2 participants
@thnkslprpt @skliper