Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE_ES_CreateChildTask ignores its StackPtr argument #2516

Closed
jphickey opened this issue Feb 14, 2024 · 0 comments · Fixed by #2517
Closed

CFE_ES_CreateChildTask ignores its StackPtr argument #2516

jphickey opened this issue Feb 14, 2024 · 0 comments · Fixed by #2517
Assignees
@jphickey
Labels
bug

Comments

@jphickey
Copy link
Contributor

Describe the bug
The implementation of CFE_ES_CreateChildTask() does not correctly pass through the stack pointer, if this is used. As a result, the child task always uses a dynamically allocated stack, not the passed-in pointer.

To Reproduce
Call CFE_ES_CreateChildTask() with a non-NULL stack pointer.
The CFE_ES_StartAppTask() underlying function always uses OSAL_TASK_STACK_ALLOCATE, not the passed-in pointer.

Expected behavior
Should use the stack pointer provided by the user, if they pass one in.

System observed on:
Debian

Reporter Info
Joseph Hickey, Vantage Systems, Inc. (reporting on behalf of user/stakeholder bug report)
@jphickey jphickey self-assigned this Feb 14, 2024
@jphickey jphickey added the bug label Feb 14, 2024
@jphickey jphickey mentioned this issue Feb 14, 2024
Closed
jphickey added a commit to jphickey/cFE that referenced this issue Feb 14, 2024
@jphickey
Fix nasa#2516, propagate stack pointer for child tasks
b04f2b1 
Update CFE_ES_CreateChildTask to propagate the user-supplied stack
pointer to the underlying OS_TaskCreate call.  Also adds a functional
test to check that the memory address of a local variable within a
child task resides within the expected stack buffer.

NOTE: this requires an additional fix to POSIX OSAL to make it work
on that platform.
@jphickey jphickey mentioned this issue Feb 14, 2024
Merged
2 tasks
jphickey added a commit to jphickey/cFE that referenced this issue Feb 26, 2024
@jphickey
Fix nasa#2516, disable custom stack test on RTEMS
50eb286
jphickey added a commit to jphickey/cFE that referenced this issue Feb 26, 2024
@jphickey
Fix nasa#2516, propagate stack pointer for child tasks
0eaba4d 
Update CFE_ES_CreateChildTask to propagate the user-supplied stack
pointer to the underlying OS_TaskCreate call.  Also adds a functional
test to check that the memory address of a local variable within a
child task resides within the expected stack buffer.

NOTE: this requires an additional fix to POSIX OSAL to make it work
on that platform.
dzbaker added a commit that referenced this issue Mar 11, 2024
@dzbaker
Merge pull request #2517 from jphickey:fix-2516-stackptr
8c4cf9b 
Fix #2516, propagate stack pointer for child tasks
@dzbaker dzbaker mentioned this issue Mar 11, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2516, propagate stack pointer for child tasks jphickey/cFE
1 participant
@jphickey