Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EDS files for latest CFE changes #2508

Closed
jphickey opened this issue Jan 31, 2024 · 0 comments · Fixed by #2510
Closed

Update EDS files for latest CFE changes #2508

jphickey opened this issue Jan 31, 2024 · 0 comments · Fixed by #2510
Assignees

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The EDS XML files are included in the main branch but not (currently) directly used, thus they need periodic re-sync to stay up to date with the latest CFE main branch changes.

Describe the solution you'd like
There are a few minor changes since the last re-sync, but mainly a cleanup:

  • CCSDS Spacepacket package belongs with the MSG module. This is actually now part of EdsLib, not CFE.
  • The FS package should be in the fs module.
  • The BASE_TYPES package is public and used by all apps. Thus it should be only be in the core_api and not core_private.
  • The CONFIG package should not be in the CFE core, it should only be in the (user-controlled) defs directory. The only copy in the CFE repo should be in sample_defs as a template/starting point.

Additional context
Somehow multiple copies of the "base_types" and "config" packages are in the tree. Unclear how this occurred, but there should be just one of each.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Jan 31, 2024
jphickey added a commit to jphickey/cFE that referenced this issue Jan 31, 2024
Cleans up multiple copies of the XML files, and minor updates to others.
Adds the FileName type to base_types.xml
Adds the FileDef structure definition to cfe_tbl.xml
jphickey added a commit to jphickey/cFE that referenced this issue Feb 1, 2024
Cleans up multiple copies of the XML files, and minor updates to others.
Adds the FileName type to base_types.xml
Adds the FileDef structure definition to cfe_tbl.xml
dzbaker added a commit that referenced this issue Feb 2, 2024
@dzbaker dzbaker closed this as completed in 7f6a082 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant