Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSG testcase passes in two bad arguments at once #2488

Closed
jphickey opened this issue Dec 19, 2023 · 0 comments · Fixed by #2489
Closed

MSG testcase passes in two bad arguments at once #2488

jphickey opened this issue Dec 19, 2023 · 0 comments · Fixed by #2489
Assignees
@jphickey

Comments

@jphickey
Copy link
Contributor

jphickey commented Dec 19, 2023 •
edited
Loading

Describe the bug
The CFE_MSG_Init() test is passing in both an invalid pointer as well as an invalid MsgID into the same invocation. While this should return an error code either way, its not clear which bad argument is producing the error.

To Reproduce
N/A

Expected behavior
Should pass in only one "bad" argument at a time.

Code snips
The test case in this line:

cFE/modules/cfe_testcase/src/msg_api_test.c

Line 52 in 7f5ebcd

UtAssert_INT32_EQ(CFE_MSG_Init(NULL, CFE_SB_INVALID_MSG_ID, sizeof(cmd)), CFE_MSG_BAD_ARGUMENT);

System observed on:
Debian

Additional context
Passing in only one bad value at a time ensures that each one is checked.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Dec 19, 2023
jphickey added a commit to jphickey/cFE that referenced this issue Dec 19, 2023
@jphickey
Fix nasa#2488, separate bad argument test
eae96f5 
Pass in CFE_SB_INVALID_MSG_ID separately from a NULL pointer.
This also required updates to the way the MSG module checks the
MsgID, as it was not using the IsValidMsgID check.
@jphickey jphickey mentioned this issue Dec 19, 2023
Merged
2 tasks
jphickey added a commit to jphickey/cFE that referenced this issue Dec 19, 2023
@jphickey
Fix nasa#2488, separate bad argument test
f83135a 
Pass in CFE_SB_INVALID_MSG_ID separately from a NULL pointer.
This also required updates to the way the MSG module checks the
MsgID, as it was not using the IsValidMsgID check.
jphickey added a commit to jphickey/cFE that referenced this issue Jan 12, 2024
@jphickey
Fix nasa#2488, correct minor whitespace error
dad4271
dzbaker added a commit that referenced this issue Jan 17, 2024
@dzbaker
Merge pull request #2489 from jphickey:fix-2488-msginit-args
dfcc3e0 
Fix #2488, separate bad argument test
@dzbaker dzbaker mentioned this issue Jan 17, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2488, separate bad argument test jphickey/cFE
1 participant
@jphickey