Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cppcheck errors reported using latest workflow update #2196

Closed
jphickey opened this issue Nov 3, 2022 · 0 comments · Fixed by #2197
Closed

Cppcheck errors reported using latest workflow update #2196

jphickey opened this issue Nov 3, 2022 · 0 comments · Fixed by #2197
Assignees
@jphickey
Labels
bug draco-rc4
Milestone
Draco

Comments

@jphickey
Copy link
Contributor

jphickey commented Nov 3, 2022

Describe the bug
The latest version of Ubuntu (with cppcheck v2.7) is reporting the following errors in the cFE repo:

severity file line issue
error /home/runner/work/cFS/cFS/source/cfe/modules/tbl/ut-coverage/tbl_UT.c 2411 Uninitialized variable: File.TblHeader
error /home/runner/work/cFS/cFS/source/cfe/modules/tbl/ut-coverage/tbl_UT.c 3067 Uninitialized variable: File.TblHeader

To Reproduce
Run latest version of static analysis workflow (depends on nasa/cFS#607)

Expected behavior
Should run cleanly

System observed on:
Ubuntu 22.04, with cppcheck v2.7

Additional context
Summary from workflow run

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Nov 3, 2022
@jphickey jphickey added the bug label Nov 3, 2022
jphickey added a commit to jphickey/cFE that referenced this issue Nov 3, 2022
@jphickey
Fix nasa#2196, resolve static analysis errors in tbl_UT.c
82349a6 
Resolves two uninitialized variable errors reported in the workflow.
@jphickey jphickey mentioned this issue Nov 3, 2022
Merged
2 tasks
jphickey added a commit to jphickey/cFE that referenced this issue Nov 3, 2022
@jphickey
Update nasa#2196, add const
664a4db
jphickey added a commit to jphickey/cFE that referenced this issue Nov 3, 2022
@jphickey
Fix nasa#2196, resolve static analysis errors
660590b 
Resolves two uninitialized variable errors reported in the workflow,
and other minor style items.  Add suppressions for endian checks
which are constant on a given arch.
dzbaker added a commit that referenced this issue Nov 3, 2022
@dzbaker
Merge pull request #2197 from jphickey/fix-2196-cppcheck
c0baee1 
Fix #2196, resolve static analysis errors in tbl_UT.c
@dzbaker dzbaker mentioned this issue Nov 14, 2022
Merged
2 tasks
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug draco-rc4
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #2196, resolve static analysis errors in tbl_UT.c jphickey/cFE
2 participants
@jphickey @dmknutsen