Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mismatched foreach in cmake function #1997

Closed
excaliburtb opened this issue Oct 12, 2021 · 1 comment · Fixed by #2012 or #2019
Closed

Mismatched foreach in cmake function #1997

excaliburtb opened this issue Oct 12, 2021 · 1 comment · Fixed by #2012 or #2019
Labels
draco-rc1 enhancement good first issue Good for newcomers
Milestone
Draco

Comments

@excaliburtb
Copy link

The endforeach args do not match the foreach args

foreach(APP ${MISSION_DEPS})
list(APPEND VARLIST "${APP}_MISSION_DIR")
endforeach(APP ${MISSION_APPS})

cFE/cmake/mission_build.cmake

Line 362 in 98f78e8

endforeach(APP ${MISSION_APPS})

@paulober
Copy link
Contributor

Maybe consider removing args from endforeach() statement, since the official CMake documentation recommends it as a deprecated arg (since 3.12) and should only be used for backward compatibility. Depends on which min. CMake version NASA uses internally on their build-servers...

paulober pushed a commit to paulober/cFE that referenced this issue Oct 13, 2021
Fix nasa#1997, Mismatched foreach in cmake func
b44b01b
paulober pushed a commit to paulober/cFE that referenced this issue Oct 30, 2021
Fix nasa#1997, Mismatched foreach in cmake func
832607f
paulober pushed a commit to paulober/cFE that referenced this issue Oct 30, 2021
Fix nasa#1997, Mismatched foreach in cmake function
203f927
paulober pushed a commit to paulober/cFE that referenced this issue Oct 30, 2021
Fix nasa#1997, Mismatched foreach in cmake function
a324fbe
@paulober paulober mentioned this issue Oct 30, 2021
Merged
paulober pushed a commit to paulober/cFE that referenced this issue Nov 3, 2021
Fix nasa#1997, Mismatched foreach in cmake function
b4d2ca8
paulober pushed a commit to paulober/cFE that referenced this issue Nov 3, 2021
Fix nasa#1997, Mismatched foreach in cmake function
0521523
astrogeco added a commit that referenced this issue Dec 8, 2021
@astrogeco
Merge pull request #2012 from pavll/fix-1997-mismatched-foreach-in-cm…
efa4640 
…ake-func

Fix #1997, Mismatched foreach in cmake function
@astrogeco astrogeco mentioned this issue Dec 15, 2021
Merged
@astrogeco astrogeco added this to the Draco milestone Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
draco-rc1 enhancement good first issue Good for newcomers
Projects
None yet
Milestone
Draco
4 participants
@excaliburtb @paulober @skliper @astrogeco