-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments/document cleanup relative to SB/MSG/SBR review (and #1375) #1452
Comments
skliper
added
docs
This change only affects documentation.
and removed
enhancement
labels
Apr 29, 2021
skliper
added a commit
to skliper/cFE
that referenced
this issue
May 24, 2021
skliper
added a commit
to skliper/cFE
that referenced
this issue
May 26, 2021
skliper
added a commit
to skliper/cFE
that referenced
this issue
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Clarify CCSDS comment, just note CCSDS maximum is 7 bigger than int16:
cFE/modules/core_api/fsw/inc/cfe_msg_api_typedefs.h
Line 48 in c8b5e00
Add link to options in documentation:
cFE/modules/core_api/fsw/inc/cfe_sb.h
Line 157 in c8b5e00
Clarify comments to eliminate implied coupling (SBN is an example use):
cFE/modules/core_api/fsw/inc/cfe_sb.h
Lines 315 to 316 in c8b5e00
Mention CFE_SB_ReleaseMessageBuffer for the case when a message is not transmitted in
CFE_SB_AllocateMessageBuffer
:cFE/modules/core_api/fsw/inc/cfe_sb.h
Line 474 in c8b5e00
Extra
a
in comment:cFE/modules/core_private/fsw/inc/cfe_sbr.h
Line 52 in c8b5e00
Comment in
CFE_SB_UnsubscribeFull
about CFE_SUCCESS status should be brought up to theelse
level, everything is success and explicitly mention in API documentation:cFE/modules/sb/fsw/src/cfe_sb_api.c
Line 1264 in c8b5e00
s/bush/bus:
cFE/modules/sbr/CMakeLists.txt
Line 33 in c8b5e00
Fix comment, doesn't pad to boundary, instead pads to be divisible by 64 so compiler won't add padding if payload structure requires 64 bit alignment:
cFE/modules/msg/option_inc/default_cfe_msg_hdr_pri.h
Line 91 in c8b5e00
cFE/modules/msg/option_inc/default_cfe_msg_hdr_priext.h
Line 77 in c8b5e00
Describe the solution you'd like
Fix
Describe alternatives you've considered
None
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: