Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document/verify CFE_RESOURCEID_MAX is power of 2 - 1 and sometimes used as MASK (and MAX) #1365

Closed
skliper opened this issue Apr 14, 2021 · 0 comments · Fixed by #1371 or #1431
Closed

Document/verify CFE_RESOURCEID_MAX is power of 2 - 1 and sometimes used as MASK (and MAX) #1365

skliper opened this issue Apr 14, 2021 · 0 comments · Fixed by #1371 or #1431
Assignees
@jphickey
Labels
CFS-40 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Apr 14, 2021

Is your feature request related to a problem? Please describe.
CFE_RESOURCEID_MAX is used in some places as MAX and others as a mask, also has to be power of 2 - 1:

cFE/modules/resourceid/fsw/src/cfe_resourceid_api.c

Line 52 in e80aae9

return (CFE_ResourceId_ToInteger(ResourceId) & ~((uint32)CFE_RESOURCEID_MAX));

Describe the solution you'd like
Document and verify

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Apr 14, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Apr 16, 2021
@jphickey
Fix nasa#1365, assert CFE_RESOURCEID_MAX is a bitmask
3ed24a5 
Add a compile time assert to ensure that this value is
actually a power of two-1.  Notes in the comments that
it serves as both a numeric limit and a mask.
jphickey added a commit to jphickey/cFE that referenced this issue Apr 16, 2021
@jphickey
Fix nasa#1365, assert CFE_RESOURCEID_MAX is a bitmask
da86146 
Add a compile time assert to ensure that this value is
actually a power of two-1.  Notes in the comments that
it serves as both a numeric limit and a mask.
@jphickey jphickey mentioned this issue Apr 16, 2021
Merged
astrogeco added a commit that referenced this issue Apr 28, 2021
@astrogeco
Merge pull request #1371 from jphickey/fix-1365-resourceid-max
68f83b1 
Fix #1365, assert CFE_RESOURCEID_MAX is a bitmask
@astrogeco astrogeco mentioned this issue Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
CFS-40 enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper