Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "PspConfig" member in config structure #1273

Closed
jphickey opened this issue Mar 31, 2021 · 0 comments · Fixed by #1274 or #1279
Closed

Remove "PspConfig" member in config structure #1273

jphickey opened this issue Mar 31, 2021 · 0 comments · Fixed by #1274 or #1279
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The "PspConfig" member does not really serve a useful purpose anymore and should be cleaned up. Issue nasa/PSP#280 will remove the PSP definition of this structure.

Describe the solution you'd like
This structure also needs to be removed from the CFE GLOBAL_CONFIGDATA object.

Additional context
This is co-dependent with nasa/PSP#280 and needs to be done in the same build cycle.

The only remaining reference to this PspConfig member object is via the CFE_PSP_VERSION macro, where the version is printed. This should be replaced with a call to CFE_PSP_GetVersionString() instead.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Mar 31, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Mar 31, 2021
@jphickey
Fix nasa#1273, remove PspConfig global object
a378409 
The `PspConfig` member is removed from the `GLOBAL_CONFIGDATA` object.

Updates the only remaining ref to this object inside the CFE_PSP_VERSION
macro to use the API function instead.

This also updates the OSAL and CFE version print to _not_ depend on the
global object too - OSAL becomes an API call and CFE can just use the
macro directly because its the same library (itself) so no linking
concern/issue.
@jphickey jphickey mentioned this issue Mar 31, 2021
Merged
@skliper skliper added this to the 7.0.0 milestone Mar 31, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Mar 31, 2021
@jphickey
Fix nasa#1273, remove PspConfig global object
e5e2953 
The `PspConfig` member is removed from the `GLOBAL_CONFIGDATA` object.

Updates the only remaining ref to this object inside the CFE_PSP_VERSION
macro to use the API function instead.

This also updates the OSAL and CFE version print to _not_ depend on the
global object too - OSAL becomes an API call and CFE can just use the
macro directly because its the same library (itself) so no linking
concern/issue.
@jphickey jphickey mentioned this issue Mar 31, 2021
Merged
jphickey added a commit to jphickey/cFE that referenced this issue Apr 2, 2021
@jphickey
Fix nasa#1273, remove PspConfig global object
9c4b36f 
The `PspConfig` member is removed from the `GLOBAL_CONFIGDATA` object.

Updates the only remaining ref to this object inside the CFE_PSP_VERSION
macro to use the API function instead.

This also updates the OSAL and CFE version print to _not_ depend on the
global object too - OSAL becomes an API call and CFE can just use the
macro directly because its the same library (itself) so no linking
concern/issue.
astrogeco added a commit that referenced this issue Apr 2, 2021
@astrogeco
Merge pull request #1274 from jphickey/fix-1273-pspconfig
0d6ceb7 
Fix #1273, remove PspConfig global object
@astrogeco astrogeco mentioned this issue Apr 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper