Consider simplifying the zero-copy SB API #1155
Comments
|
I'd like to fit this in Caelum if we can, lower priority than the rest but a goal. |
jphickey
added a commit
to jphickey/cFE
that referenced
this issue
Mar 23, 2021
The separate zero copy handle type is removed. Adds two new simplified functions CFE_SB_AllocateMessageBuffer and CFE_SB_ReleaseMessageBuffer to replace CFE_SB_ZeroCopyGetPtr and CFE_SB_ZeroCopyGetPtr. These new functions do not use a separate Handle. Updates the CFE_SB_TransmitBuffer() API to also remove the handle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
After some refactoring in PR #1154 the whole
CFE_SB_ZeroCopyHandle_thas become somewhat extraneous - there is no extra handle/descriptor for a zero copy buffer - they are all the same, and this simply refers to the same buffer descriptor now.Describe the solution you'd like
The API can be simplified and this extra handle removed. The buffer content pointer is good enough to reconstitute the descriptor pointer (fixed offset).
Describe alternatives you've considered
Leave API as is (backward compatible, just a little more complex than it needs to be).
Additional context
This will affect public APIs - CFE_SB_ZeroCopyGetPtr, CFE_SB_ZeroCopyReleasePtr, CFE_SB_TransmitBuffer. (CFE_SB_ZeroCopySend and CFE_SB_ZeroCopyPass are affected but already deprecated).
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: